Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support description metadata #9585

Merged
merged 2 commits into from
Jan 6, 2024
Merged

feat: support description metadata #9585

merged 2 commits into from
Jan 6, 2024

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jan 6, 2024

Supports both description and _description metadata.

Fixes #9584

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (305cabf) 74.36% compared to head (04e8bab) 74.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9585      +/-   ##
==========================================
- Coverage   74.36%   74.35%   -0.02%     
==========================================
  Files         536      536              
  Lines       23162    23158       -4     
  Branches     4049     4049              
==========================================
- Hits        17225    17218       -7     
- Misses       4836     4838       +2     
- Partials     1101     1102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Jan 6, 2024
@yufeih yufeih reopened this Jan 6, 2024
@yufeih yufeih merged commit 44ca36f into main Jan 6, 2024
8 checks passed
@yufeih yufeih deleted the desc branch January 6, 2024 03:12
Comment on lines 6 to 8
<meta name="title" content="Class Cat<T, K>
| docfx seed website ">

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yufeih any idea why these have new lines appended to them? I only see this in API generation, the conceptual articles are correct with a single line title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are caused by the changes here and isn't specific to API pages, e.g. this one

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* feat: support description metadata

* test(snapshot): update snapshots f767f49 for ubuntu-latest

---------

Co-authored-by: yufeih <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Include API summary in <meta description> tag
2 participants